RE: [PATCH v3] VIM: Improve moving between messages in a thread

Subject: RE: [PATCH v3] VIM: Improve moving between messages in a thread

Date: Tue, 13 Jan 2015 00:47:19 +0100

To: Ian Main, notmuch@notmuchmail.org

Cc:

From: Bartosz Telenczuk

Hi Ian,

The patch looks good. I tested it on my system and it works fine.  I just have one suggestion regarding coding style.

> +function! s:show_prev_msg()
>  function! s:show_next_msg()

Since these functions are almost the same, you could avoid code repetition by replacing them by a function which takes (positive or negative) increment as an argument.

Cheers,

Bartosz

• Previous message (by thread): RE: [PATCH v3] VIM: Improve moving between messages in a thread

Thread:

• Ian Main—[PATCH] Improve moving between messages in a thread [inbox, notmuch::obsolete, notmuch::patch, notmuch::vim, unread]
  • Ian Main—RE: [PATCH] Improve moving between messages in a thread [inbox, unread]
  • Ian Main—[PATCH] VIM: Improve moving between messages in a thread [inbox, notmuch::obsolete, notmuch::patch, notmuch::vim, unread]
    • Franz Fellner—Re: [PATCH] VIM: Improve moving between messages in a thread [inbox, unread]
      • Ian Main—Re: [PATCH] VIM: Improve moving between messages in a thread [inbox, unread]
        • Franz Fellner—Re: [PATCH] VIM: Improve moving between messages in a thread [inbox, unread]
          • Tomi Ollila—Re: [PATCH] VIM: Improve moving between messages in a thread [inbox, unread]
    • Ian Main—[PATCH v3] VIM: Improve moving between messages in a thread [inbox, notmuch::moreinfo, notmuch::patch, notmuch::vim, unread]
      • Bartosz Telenczuk—RE: [PATCH v3] VIM: Improve moving between messages in a thread [inbox, unread]
        • Franz Fellner—RE: [PATCH v3] VIM: Improve moving between messages in a thread [inbox, unread]
          • Bartosz Telenczuk—RE: [PATCH v3] VIM: Improve moving between messages in a thread [inbox, unread]