Quoth Justus Winter on May 13 at 11:51 pm: > Hi Austin, > > thanks for taking care of this. > > Quoting Austin Clements (2012-05-13 21:57:06) > > --- > > bindings/go/src/notmuch/notmuch.go | 13 +++++++------ > > bindings/python/notmuch/database.py | 4 ++-- > > A change to the python bindings slipped into this one. Sure enough. I'll send a v2 that moves that hunk to the python patch. > Other than that this looks good. > > I just saw that I marked another function as problematic, > notmuch_database_find_message_by_filename ends up calling > _notmuch_directory_create that aborts if the database is not > writable. But this might have to wait and might not even requira an > api change. Right. notmuch_database_find_message_by_filename already has a status return, so its API is fine. (Actually, I was starting to fix its implementation when I realized notmuch_database_get_directory was problematic.) > Justus