Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory

Subject: Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory

Date: Sun, 13 May 2012 23:51:35 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Justus Winter

Hi Austin,

thanks for taking care of this.

Quoting Austin Clements (2012-05-13 21:57:06)
> ---
>  bindings/go/src/notmuch/notmuch.go  |   13 +++++++------
>  bindings/python/notmuch/database.py |    4 ++--

A change to the python bindings slipped into this one.

Other than that this looks good.

I just saw that I marked another function as problematic,
notmuch_database_find_message_by_filename ends up calling
_notmuch_directory_create that aborts if the database is not
writable. But this might have to wait and might not even requira an
api change.

Justus

• Previous message (by thread): Re: [PATCH v2 0/5] Fix notmuch_database_get_directory API

Thread:

• Austin Clements—[PATCH 0/5] Fix notmuch_database_get_directory API [inbox, unread]
  • Austin Clements—[PATCH 1/5] lib/cli: Make notmuch_database_get_directory return a status code [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 2/5] go: Update for changes to notmuch_database_get_directory [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Justus Winter—Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory [inbox, notmuch::review, unread]
      • Austin Clements—Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory [inbox, unread]
  • Austin Clements—[PATCH 3/5] python: Update for changes to notmuch_database_get_directory [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 4/5] ruby: Update for changes to notmuch_database_get_directory [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Austin Clements—[PATCH 5/5] news: Update for changes to notmuch_database_get_directory [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Tomi Ollila—Re: [PATCH 0/5] Fix notmuch_database_get_directory API [inbox, notmuch::review, unread]
    • Justus Winter—Re: [PATCH 0/5] Fix notmuch_database_get_directory API [inbox, notmuch::review, unread]
  • Austin Clements—[PATCH v2 0/5] Fix notmuch_database_get_directory API [inbox, unread]
    • Austin Clements—[PATCH v2 1/5] lib/cli: Make notmuch_database_get_directory return a status code [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 2/5] go: Update for changes to notmuch_database_get_directory [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 3/5] python: Update for changes to notmuch_database_get_directory [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 4/5] ruby: Update for changes to notmuch_database_get_directory [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 5/5] news: Update for changes to notmuch_database_get_directory [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 0/5] Fix notmuch_database_get_directory API [inbox, unread]