Quoting Tomi Ollila (2012-05-13 22:49:58) > On Sun, May 13 2012, Austin Clements <amdragon@MIT.EDU> wrote: > > > This is a proposed last-minute change for 0.13. It fixes the > > notmuch_database_get_directory API in the same way we're fixing > > notmuch_database_open, etc in this release. Since this is a > > backwards-incompatible change, it would be nice to lump it with the > > other API-breaking changes. > > > > To keep the patch simple, this does not change the behavior of > > notmuch_database_get_directory, but it puts us in a good position to > > fix it in the future. > > Looks good to me (and applied in my current environment). The c/c++ > changes were easy to understand and the python/go/ruby binding > changes looks like the old changes -- but those who understand more > (and actually uses those bindings) could do better review. I'd say the changes to the python and go bindings are fine. > It would be nice to get those in so that we may have chance not > updating SONAME for notmuch 0.14. Yes, I'd love to see this in 0.13 as well, but I don't really see the problem with breaking the api if this fixes design issues. After all, notmuch is young and so are all the projects building uppon it. Justus