Re: Patch: Flush and Reopen

Subject: Re: Patch: Flush and Reopen

Date: Fri, 09 Sep 2011 20:43:53 -0400

To: Austin Clements

Cc: Notmuch developer list

From: Martin Owens

On Fri, 2011-09-09 at 19:40 -0400, Austin Clements wrote:
> (indented correctly, of course).  Reopen is a method of
> Xapian::Database, which is what notmuch->xapian_db is anyway (unlike,
> flush, which is a member of the subclass WritableDatabase and hence
> requires the cast).  And reopening is a sensible thing to do on both
> read-only and read/write databases.

See attached for the removal of the cast and conditional for reopen.

> Also, in keeping with notmuch code style, you should use tabs for
> indentation and put a space before the open paren argument lists. 

I couldn't detect a consistant style for the tab/spacing and it confused
me greatly. Especially coming from python where spacing is critical.

I've put in tabs, not sure if I've put in enough in the form required.

Best Regards, Martin Owens