Re: Patch: Flush and Reopen

Subject: Re: Patch: Flush and Reopen

Date: Thu, 08 Sep 2011 22:54:21 -0400

To: Austin Clements

Cc: Paul Tagliamonte, Notmuch developer list

From: Martin Owens

Hey Austin,

Thanks for the review :-) I'll attempt to fix some of the style
guidelines, but see below.

On Thu, 2011-09-08 at 22:42 -0400, Austin Clements wrote:
> Did you mean to change this?

This fails to build on Ubuntu maverick with the extra .3 and I see no
reason to have that sub-minor version. Pushing it in would probably be
useful unless there is a real reason.

> This cast will fail.  Shouldn't this just be a wrapper around
> notmuch->xapian_db->reopen? 

I'm a python programmer, c wrappers are beyond me unfortunately. Your
help implementing that would be really good.

Best regards, Martin Owens