Re: [PATCH 2/3] show: Use consistent header ordering in the text format

Subject: Re: [PATCH 2/3] show: Use consistent header ordering in the text format

Date: Fri, 20 Jan 2012 15:45:39 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

On Wed, 18 Jan 2012 15:28:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Previously, top-level message headers were printed as Subject, From,
> To, Date, while embedded message headers were printed From, To,
> Subject, Date.  This makes both cases use the former order and updates
> the tests accordingly.
> 
> Strangely, the raw format also uses this function, so this also fixes
> the two raw format tests affected by this change.
> ---

LGTM (this patch).

Tomi

Previous message (by thread): Re: [PATCH v5 0/2] Second step of 'show' rewrite

Thread:

Austin Clements—[PATCH 0/3] Second step of 'show' rewrite [inbox, unread]
- Austin Clements—[PATCH 1/3] mime node: Record depth-first part numbers [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jani Nikula—Re: [PATCH 1/3] mime node: Record depth-first part numbers [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 1/3] mime node: Record depth-first part numbers [inbox, unread]
      - Austin Clements—Re: [PATCH 1/3] mime node: Record depth-first part numbers [inbox, unread]
- Austin Clements—[PATCH 2/3] show: Use consistent header ordering in the text format [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 2/3] show: Use consistent header ordering in the text format [inbox, notmuch::review, unread]
- Austin Clements—[PATCH 3/3] show: Introduce mime_node formatter callback [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jani Nikula—Re: [PATCH 3/3] show: Introduce mime_node formatter callback [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 3/3] show: Introduce mime_node formatter callback [inbox, unread]
- Dmitry Kurochkin—Re: [PATCH 0/3] Second step of 'show' rewrite [inbox, unread]
  - Austin Clements—Re: [PATCH 0/3] Second step of 'show' rewrite [inbox, unread]
- Jameson Graef Rollins—Re: [PATCH 0/3] Second step of 'show' rewrite [inbox, notmuch::review, signed, unread]
- Austin Clements—[PATCH v2 0/3] Second step of 'show' rewrite [inbox, unread]
  - Austin Clements—[PATCH v2 1/3] mime node: Record depth-first part numbers [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Jani Nikula—Re: [PATCH v2 1/3] mime node: Record depth-first part numbers [inbox, notmuch::review, unread]
    - Tomi Ollila—Re: [PATCH v2 1/3] mime node: Record depth-first part numbers [inbox, notmuch::review, unread]
    - Dmitry Kurochkin—Re: [PATCH v2 1/3] mime node: Record depth-first part numbers [inbox, notmuch::review, unread]
      - Austin Clements—Re: [PATCH v2 1/3] mime node: Record depth-first part numbers [inbox, unread]
  - Austin Clements—[PATCH v2 2/3] show: Use consistent header ordering in the text format [inbox, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v2 3/3] show: Introduce mime_node formatter callback [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Tomi Ollila—Re: [PATCH v2 3/3] show: Introduce mime_node formatter callback [inbox, notmuch::review, unread]
    - Dmitry Kurochkin—Re: [PATCH v2 3/3] show: Introduce mime_node formatter callback [inbox, notmuch::review, unread]
      - Austin Clements—Re: [PATCH v2 3/3] show: Introduce mime_node formatter callback [inbox, unread]
- Austin Clements—[PATCH v3 0/2] Second step of 'show' rewrite [inbox, unread]
  - Austin Clements—[PATCH v3 1/2] mime node: Record depth-first part numbers [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v3 2/2] show: Introduce mime_node formatter callback [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH v4 0/3] Second step of 'show' rewrite [inbox, unread]
  - Austin Clements—[PATCH v4 1/3] mime node: Record depth-first part numbers [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v4 2/3] show: Use consistent header ordering in the text format [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v4 3/3] show: Introduce mime_node formatter callback [inbox, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH v5 0/2] Second step of 'show' rewrite [inbox, unread]
  - Austin Clements—[PATCH v5 1/2] mime node: Record depth-first part numbers [inbox, notmuch::patch, notmuch::pushed, unread]
    - Dmitry Kurochkin—Re: [PATCH v5 1/2] mime node: Record depth-first part numbers [inbox, notmuch::review, unread]
    - Tomi Ollila—Re: [PATCH v5 1/2] mime node: Record depth-first part numbers [inbox, notmuch::review, unread]
  - Austin Clements—[PATCH v5 2/2] show: Introduce mime_node formatter callback [inbox, notmuch::patch, notmuch::pushed, unread]
    - Dmitry Kurochkin—Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback [inbox, notmuch::review, unread]
    - Tomi Ollila—Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback [inbox, notmuch::review, unread]
    - Jani Nikula—Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback [inbox, unread]
  - David Bremner—Re: [PATCH v5 0/2] Second step of 'show' rewrite [inbox, unread]