Re: [PATCH] test: do not add legacy bindings to PYTHONPATH

Subject: Re: [PATCH] test: do not add legacy bindings to PYTHONPATH

Date: Mon, 23 Jun 2025 13:05:14 +0300

To: michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org

Cc: Michael J Gruber

From: Tomi Ollila

On Fri, Jun 20 2025, michaeljgruber wrote:

> From: Michael J Gruber <git@grubix.eu>
>
> d526797a ("python: move legacy python bindings to contrib.", 2025-02-15)
> moved the legacy python bindings away from the location in `bindingss/`.
> Do not add that location to the PYTHONPATH since it is obsolete.

If tests still work then this is GOOD :D

Tomi

> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 059e110c..5b3cd454 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -896,7 +896,7 @@ test_done () {
>  test_python () {
>      # Note: if there is need to print debug information from python program,
>      # use stdout = os.fdopen(6, 'w') or stderr = os.fdopen(7, 'w')
> -    PYTHONPATH="$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage:$NOTMUCH_SRCDIR/bindings/python${PYTHONPATH:+:$PYTHONPATH}" \
> +    PYTHONPATH="$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage${PYTHONPATH:+:$PYTHONPATH}" \
>  	$NOTMUCH_PYTHON -B - > OUTPUT
>  }
>  
> -- 
> 2.50.0.135.g8da7ba24c6
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: