Re: [PATCH] emacs: add compatability functions for emacs 23

Subject: Re: [PATCH] emacs: add compatability functions for emacs 23

Date: Wed, 26 Oct 2016 21:28:48 -0700

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Matt Armstrong


Mark Walters <markwalters1009@gmail.com> writes:

> +;; Compatability functions for emacs 23.
> +
> +(unless (fboundp 'setq-local)
> +  (defmacro setq-local (var val)
> +    `(set (make-local-variable ',var) ,val)))

A concern I have with this approach is that it modifies symbols outside
the notmuch namespace.  Could people on old Emacsen come to rely on the
newer Emacs interfaces inadvertently, and wonder how they came to be,
etc?

The only other package I have non-trivial experience working with is
Gnus, and the practice there was to place portability interfaces in the
gnus- namespace, and refrain from calling the "native" interfaces
directly.

Outside Gnus, I'm ignorant of what Emacs packages typically do for this
problem.  I have no strong feelings either way.

Thread: