On Tue, 25 Oct 2016, David Bremner <david@tethera.net> wrote: > Mark Walters <markwalters1009@gmail.com> writes: > >> Some of the recent changes to the emacs code have used functions >> introduced in emacs 24. The functions used are read-char-choice and >> setq-local. This changeset adds compatability functions to >> notmuch-lib so that it should work on emacs 23. >> >> --- >> >> Hi >> >> I tried compiling under emacs 23 recently and noticed that some recent >> changes have used some features introuduced in emacs 24. I think we >> still support emacs 23 so this changeset adds two compatability >> functions. > > Hi Mark; > > Can you give me a recipe to reproduce the failures in emacs23? I only > get warnings when building. Of course I believe that things will go > wrong at some point calling non-existent functions. Hi You can make the read-char-choice fail by setting the fcc header to use insert (the default), locking the database (eg doing notmuch tag --batch), composing and sending a message. The Fcc will fail, which will trigger the error. For the setq-local start to compose a message, and then run M-x notmuch-address-toggle-internal-completion This will give the error. Best wishes Mark