Re: [PATCH 24/24] devel: add script to test out-of-tree builds

Subject: Re: [PATCH 24/24] devel: add script to test out-of-tree builds

Date: Tue, 26 Sep 2017 08:32:11 +0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

On Tue, Sep 26 2017, Tomi Ollila wrote:

>> +
>> +set -eu
>> +
>> +srcdir="$(cd "$(dirname "$0")"/.. && pwd)"
>
> quotes unnecessary above, but may clarify things...

outmost quotes, that is -- e.g. srcdir=$(cd "$(dirname "$0")"/.. && pwd)
-- other quotes are necessary

>
>> +builddir=$(mktemp -d)
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Previous message (by thread): Re: [PATCH] NEWS: test suite out-of-tree builds

Thread:

Jani Nikula—[PATCH 00/24] test: separate source and build directories [inbox, unread]
- Jani Nikula—[PATCH 01/24] test: use corpora/default not corpus in T480-hex-escaping.sh [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
- Jani Nikula—[PATCH 02/24] build: use NOTMUCH_SRCDIR for referencing notmuch-test [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 03/24] test: use $(dirname "$0") for sourcing test-lib.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 04/24] perf-test: use $(dirname "$0") for sourcing perf-test-lib.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 05/24] test: check for notmuch binary in test-lib.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 06/24] test: add a script to figure out source and build directories [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 07/24] test: use source and build paths in test-lib.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 08/24] perf-test: use source and build paths in perf-test-lib.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 09/24] test: use source and build paths in test-lib-common.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 10/24] test: mkdir and cd to $TMP_DIRECTORY instead of $test for testing [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 11/24] test: use source and build paths in notmuch-test [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 12/24] test: use source and build paths in T000-basic.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 13/24] test: use source and build paths in T160-json.sh and T170-sexp.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 14/24] test: use source and build paths in T260-thread-order.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 15/24] test: use source and build paths in T310-emacs.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 16/24] test: use source and build paths in T350-crypto.sh [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH 17/24] test: use source and build paths in T355-smime.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 18/24] test: use source and build paths in T360-symbol-hiding.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 19/24] test: use source and build paths in T380-atomicity.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 20/24] test: use source and build paths in T4?0-emacs-*.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 21/24] test: use source and build paths in T480-hex-escaping.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 22/24] test: use source and build paths in T590-thread-breakage.sh [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 23/24] build: don't copy the test directory for out-of-tree builds [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH 24/24] devel: add script to test out-of-tree builds [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 24/24] devel: add script to test out-of-tree builds [inbox, unread]
    - Tomi Ollila—Re: [PATCH 24/24] devel: add script to test out-of-tree builds [inbox, unread]
- David Bremner—Re: [PATCH 00/24] test: separate source and build directories [inbox, unread]
  - Jani Nikula—[PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup [inbox, notmuch::patch, notmuch::pushed, unread]
    - Jani Nikula—Re: [PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup [inbox, unread]
    - David Bremner—Re: [PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup [inbox, unread]
      - Jani Nikula—[PATCH v2] test: use source path in add_gnupg_home [inbox, notmuch::patch, notmuch::pushed, unread]
      - Jani Nikula—Re: [PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup [inbox, unread]
        Jani Nikula—[PATCH] NEWS: test suite out-of-tree builds [inbox, notmuch::patch, notmuch::pushed, unread]
        David Bremner—Re: [PATCH] NEWS: test suite out-of-tree builds [inbox, unread]
        David Bremner—Re: [PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup [inbox, unread]