Re: [PATCH] Ignore encrypted parts when indexing.

Subject: Re: [PATCH] Ignore encrypted parts when indexing.

Date: Wed, 28 Dec 2011 13:40:42 +0100

To: Jameson Graef Rollins, Notmuch Mail

Cc:

From: Xavier Maillard

Hi Jameson,

On Tue, 27 Dec 2011 09:11:41 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> It appears to be an oversight that encrypted parts were indexed
> previously.  The terms generated from encrypted parts are meaningless
> and do nothing but add bloat to the database.  It is not worth
> indexing the encrypted content, just as it's not worth indexing the
> signatures in signed parts.

+1 for this.

But,

> +	    if (GMIME_IS_MULTIPART_ENCRYPTED (multipart)) {
> +		/* Don't index encrypted parts. */
> +		continue

This needs a semicolon, doesn't it ?

/Xavier

Thread: