On Sat, May 01 2021, Felipe Contreras wrote:

LGTM

> In test-lib-emacs.sh line 20:
>     test_require_external_prereq ${TEST_EMACS} || ret=1
>                                  ^-----------^ SC2086: Double quote to prevent globbing and word splitting.
>
> Did you mean:
>     test_require_external_prereq "${TEST_EMACS}" || ret=1
>
> In test-lib-emacs.sh line 21:
>     test_require_external_prereq ${TEST_EMACSCLIENT} || ret=1
>                                  ^-----------------^ SC2086: Double quote to prevent globbing and word splitting.
>
> Did you mean:
>     test_require_external_prereq "${TEST_EMACSCLIENT}" || ret=1
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  test/test-lib-emacs.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/test-lib-emacs.sh b/test/test-lib-emacs.sh
> index 3075fa59..bf875a28 100644
> --- a/test/test-lib-emacs.sh
> +++ b/test/test-lib-emacs.sh
> @@ -16,8 +16,8 @@
>  
>  test_require_emacs () {
>      local ret=0
> -    test_require_external_prereq ${TEST_EMACS} || ret=1
> -    test_require_external_prereq ${TEST_EMACSCLIENT} || ret=1
> +    test_require_external_prereq "$TEST_EMACS" || ret=1
> +    test_require_external_prereq "$TEST_EMACSCLIENT" || ret=1
>      test_require_external_prereq dtach || ret=1
>      return $ret
>  }
> -- 
> 2.31.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org