Re: [PATCH 06/13] test: add prereqs check in test_emacs_expect_t

Subject: Re: [PATCH 06/13] test: add prereqs check in test_emacs_expect_t

Date: Sat, 01 May 2021 23:18:50 +0300

To: Felipe Contreras, notmuch@notmuchmail.org

Cc: Daniel Kahn Gillmor

From: Tomi Ollila


On Sat, May 01 2021, Felipe Contreras wrote:

> test_emacs may update the external prereqs, in which case we want to
> skip the test rather than fail.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  test/test-lib.sh | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 1067316d..72ac2e89 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -592,6 +592,9 @@ test_emacs_expect_t () {
>  		exec 1>&6 2>&7		# Restore stdout and stderr
>  		inside_subtest=
>  
> +		# test_emacs may update missing external prerequisites
> +		test_check_missing_external_prereqs_ "$test_subtest_name" && return
> +

Ditto. LGTM.

Tomi

>  		# Report success/failure.
>  		result=$(cat OUTPUT)
>  		if [ "$result" = t ]
> -- 
> 2.31.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: