Re: [PATCH v2 05/10] install: check for non-SysV version (Solaris support)

Subject: Re: [PATCH v2 05/10] install: check for non-SysV version (Solaris support)

Date: Tue, 06 Nov 2012 18:51:43 +0200

To: Blake Jones, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Mon, Nov 05 2012, Blake Jones <blakej@foo.net> wrote:

Some quick comments, haven't got time to test yet.

// stuff deleted //

> diff --git a/vim/Makefile b/vim/Makefile
> index f17bebf..7ceba7a 100644
> --- a/vim/Makefile
> +++ b/vim/Makefile
> @@ -5,8 +5,6 @@ files = plugin/notmuch.vim \
>  prefix = $(HOME)/.vim
>  destdir = $(prefix)/plugin
>  
> -INSTALL = install -D -m644
> -
>  all: help
>  
>  help:
> @@ -17,7 +15,7 @@ help:
>  	@echo "    make symlink     - create symlinks in ~/.vim (useful for development)"
>  
>  install:
> -	@for x in $(files); do $(INSTALL) $(CURDIR)/$$x $(prefix)/$$x; done
> +	@for x in $(files); do $(INSTALL) -D -m644 $(CURDIR)/$$x $(prefix)/$$x; done
>  
> -link symlink: INSTALL = ln -fs
>  link symlink: install
> +	@for x in $(files); do ln -fs $(CURDIR)/$$x $(prefix)/$$x; done
> -- 

Here you'd need to remove the 'install' dependency as it would first
do it and then overwriting the results with dependency..

another option is to use other variable like 

__INSTALL = $(INSTALL) -D -m644

and then replace other uses of INSTALL with __INSTALL

(this doesn't look too good but that was what I could come
quickly)

> 1.7.3.2

Tomi

Thread: