On Thu, Nov 08 2012, Blake Jones <blakej@foo.net> wrote: >>> @@ -11,10 +12,44 @@ fi >>> HEADER=$1 >>> shift >>> >>> +if [ `uname -s` == SunOS ] ; then >>> + # >>> + # Using Solaris "nm", a defined symbol looks like this: >>> + # >> >> The POSIX / Bourne -comformant equality comparison is '='. > > Sigh, of course it is. Fixed. > >> e.g. >> >> $ ./heirloom-sh/sh -c ' [ a == b ] || echo x' >> ./heirloom-sh/sh: test: unknown operator == >> zsh: exit 1 ./heirloom-sh/sh -c ' [ a == b ] || echo x' >> >> Interesting that Solaris /bin/sh did not fail there... > > I was running on Solaris 11.1, which uses ksh93 as its /bin/sh. You're > absolutely right that Solaris 10 would fall over, though. > > Similarly, the following line: > > demangled=$(demangle $sym) > > doesn't work on traditional sh. I've replaced $() with ``. > >> Hmm, gen-version-script doesn't have shebang... it is run like: >> >> sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@ >> >> in lib/Makefile.local -- taking sh fron PATH. > > I updated the first line from the #! invocation to a comment saying > > # This script is invoked via "sh .../gen-version-script.sh". looks good > Would a respun version of these patches help toward testing? $ grep vim test/* zsh: exit 1 grep vim test/* i.e. no vim tests... Also, as *I* will execute my tests in Linux these won't make things fail -- and probably no-one else eager to test won't have problems either So I think these patches are good until someone(tm) finds other issues (if any), > Blake Tomi