Re: [Patch v3] util: add gzreadline

Subject: Re: [Patch v3] util: add gzreadline

Date: Sun, 30 Mar 2014 19:13:36 +0300

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sun, Mar 30 2014, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> "On error, gzgets() shall return Z_NULL.
>>
>> In light of this I'd say no. can we set out-of-memory using some public
>> api so it is available using gzerror()
>>
>>
>
> Since we already "broke" the API, what about
>
> 1) start a "util_status_t" enum, later unify that with the hex_ return codes.
>
> 2) 
>
> util_status_t
> gz_getline (void *ctx, char **buf, size_t *bufsize, ssize_t *bytes_read,
>            gzFile stream);

that looks unobjectionable to me :D

>
> d

Tomi

Thread: