Re: [Patch v2 2/3] util: add gzreadline

Subject: Re: [Patch v2 2/3] util: add gzreadline

Date: Sun, 30 Mar 2014 08:03:16 -0300

To: notmuch@notmuchmail.org

Cc:

From: David Bremner

David Bremner <david@tethera.net> writes:


> +	if (!gzgets (stream, buf + offset, len))
> +	    return -1;

I did find one bug by setting the initial line size to 2. This should
read "len - offset".

• Previous message (by thread): Re: [PATCH 0/2] cli: notmuch dump abstractions

Thread:

• Jani Nikula—[PATCH 0/2] cli: notmuch dump abstractions [inbox, unread]
  • Jani Nikula—[PATCH 1/2] cli: abstract database dumping from the dump command [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH 2/2] cli: abstract dump file open from the dump command [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—[PATCH v2] cli: abstract dump file open from the dump command [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—Re: [PATCH 0/2] cli: notmuch dump abstractions [inbox, unread]
    • David Bremner—[PATCH] RFC: impliment gzipped output for notmuch dump [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Tomi Ollila—Re: [PATCH] RFC: impliment gzipped output for notmuch dump [inbox, unread]
      • Jani Nikula—Re: [PATCH] RFC: impliment gzipped output for notmuch dump [inbox, unread]
        • David Bremner—Re: [PATCH] RFC: impliment gzipped output for notmuch dump [inbox, unread]
          • Jani Nikula—Re: [PATCH] RFC: impliment gzipped output for notmuch dump [inbox, unread]
            • David Bremner—Re: [PATCH] RFC: impliment gzipped output for notmuch dump [inbox, unread]
      • David Bremner—[PATCH] dump: support gzipped output [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner— [inbox, unread]
          • David Bremner—[Patch v2 1/3] dump: support gzipped output [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—[Patch v2 2/3] util: add gzreadline [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Tomi Ollila—Re: [Patch v2 2/3] util: add gzreadline [inbox, unread]
              • David Bremner—[Patch v3] util: add gzreadline [inbox, notmuch::obsolete, notmuch::patch, unread]
                • Tomi Ollila—Re: [Patch v3] util: add gzreadline [inbox, unread]
                  • David Bremner—Re: [Patch v3] util: add gzreadline [inbox, unread]
                    • Tomi Ollila—Re: [Patch v3] util: add gzreadline [inbox, unread]
            • David Bremner—Re: [Patch v2 2/3] util: add gzreadline [inbox, unread]
          • David Bremner—[Patch v2 3/3] restore: transparently support gzipped input [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—Re: [PATCH 0/2] cli: notmuch dump abstractions [inbox, unread]