On Mon, Jun 13 2016, David Bremner <david@tethera.net> wrote: > The choice of array implementation is deliberate, for future iterator support > --- > lib/Makefile.local | 1 + > lib/notmuch-private.h | 11 ++++ > lib/string-map.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 165 insertions(+) > create mode 100644 lib/string-map.c > > diff --git a/lib/Makefile.local b/lib/Makefile.local > index beb9635..9280880 100644 > --- a/lib/Makefile.local > +++ b/lib/Makefile.local > @@ -40,6 +40,7 @@ libnotmuch_c_srcs = \ > $(dir)/messages.c \ > $(dir)/sha1.c \ > $(dir)/built-with.c \ > + $(dir)/string-map.c \ > $(dir)/tags.c I suggest everyone to install editor which supports showing tabs & spaces e.g. in different color and also visualizes trailing whitespace & trailing empty lines... ... personally I've been pretty happy with ethan-wspace in emacs to do that (I did M-x ethan-wspace-highlight-tabs-mode (in notmuch-show mode buffer) to recognize the above). If there is no need to further changes then the above can IMO go in -- the same "dirtiness" can be observed in $(dir)/query-fp.cc 10 lines below... HTH. Tomi