Re: [PATCH] add has: query prefix to search for specific properties

Subject: Re: [PATCH] add has: query prefix to search for specific properties

Date: Sun, 17 Jul 2016 07:38:10 -0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

David Bremner <david@tethera.net> writes:

> Do we want to have the same prefix listed in BOOLEAN_PREFIX_INTERNAL and
> BOOLEAN_PREFIX_EXTERNAL? this seems quite fragile. If we don't though,
> we have to use the same prefix name for queries as in the code (which is
> already sprinkled with _find_prefix ("property") ).

Thinking about it a bit more, there's really no problem here. The
invariant to maintain is the names are unique across all 3 tables used
by _find_prefix, not the necessarily the prefixes. Indeed there's
already the example of "is" and "tag".

d

• Previous message (by thread): Re: [PATCH] add has: query prefix to search for specific properties

Thread:

• David Bremner—message properties patches, v1.0 [inbox, unread]
  • David Bremner—[PATCH 1/8] lib: read "property" terms from messages. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 2/8] lib: private string map (associative array) API [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 2/8] lib: private string map (associative array) API [inbox, unread]
      • David Bremner—Re: [PATCH 2/8] lib: private string map (associative array) API [inbox, unread]
        • Bijan Chokoufe Nejad—Re: [PATCH 2/8] lib: private string map (associative array) API [inbox, unread]
  • David Bremner—[PATCH 3/8] lib: basic message-property API [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—[PATCH] n_m_remove_property(msg, key, NULL) should removes all properties with key [inbox, notmuch::obsolete, notmuch::patch, notmuch::wip, unread]
      • David Bremner—[PATCH] RFC: all deleting all properties with a given key [inbox, notmuch::obsolete, notmuch::patch, notmuch::wip, unread]
        • Daniel Kahn Gillmor—Re: [PATCH] RFC: all deleting all properties with a given key [inbox, unread]
  • David Bremner—[PATCH 4/8] lib: extend private string map API with iterators [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 5/8] lib: iterator API for message properties [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 6/8] CLI: refactor dumping of tags. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 7/8] CLI: add properties to dump output [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 8/8] cli: optionally restore message properties from dump file [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—[PATCH] add has: query prefix to search for specific properties [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH] add has: query prefix to search for specific properties [inbox, unread]
        • David Bremner—Re: [PATCH] add has: query prefix to search for specific properties [inbox, unread]
        • Daniel Kahn Gillmor—Re: [PATCH] add has: query prefix to search for specific properties [inbox, unread]