Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

Subject: Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

Date: Thu, 28 Mar 2019 11:34:34 +0000

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote:

> David Edmondson <dme@dme.org> writes:
>
>
>> +(defun notmuch-show--browse-urls ()
>> +  "Offer to browse any URLs in the current message."
>> +  (interactive)
>> +  (let ((urls (notmuch-show--gather-urls)))
>> +    (if urls
>> +	(browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car urls)))
>> +      (message "No URLs found."))))
>> +
>>  (provide 'notmuch-show)
>
> It's a minor point, but should this really have -- to signal a private
> function? It's bound to key which sortof makes it defacto public, no?

Yes.

Do you want an updated patch or will you fix it on the fly?

dme.
-- 
I'm catching up with myself!
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: