Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

Subject: Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

Date: Thu, 28 Mar 2019 08:23:37 -0300

To: David Edmondson, notmuch@notmuchmail.org

Cc:

From: David Bremner


David Edmondson <dme@dme.org> writes:


> +(defun notmuch-show--browse-urls ()
> +  "Offer to browse any URLs in the current message."
> +  (interactive)
> +  (let ((urls (notmuch-show--gather-urls)))
> +    (if urls
> +	(browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car urls)))
> +      (message "No URLs found."))))
> +
>  (provide 'notmuch-show)

It's a minor point, but should this really have -- to signal a private
function? It's bound to key which sortof makes it defacto public, no?

d


_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: