Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

Subject: Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

Date: Sun, 19 Oct 2014 13:02:28 +0300

To: Michal Sojka, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

Hi Michal, been busy lately so I haven't got into this...

... I'll look into it in a bit more detail a bit later, 


On Tue, Oct 14 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:

>
> I don't know. You seem to think about this in the opposite way than how
> it is implemented. The implementation really filters things out whereas
> you specify what not to filter.
>
> My feeling is that if you would implement your proposal, the code would
> be more complex than in my patch, because the mapping between command
> line options and the actual algorithm would require some extra code. And
> in a previous comment, you preferred simplicity.

Yes, maybe the choice of reusing --duplicate was bad, and perhaps took
thought from the main point -- what kind output options should be possible...

> Hopefully, you consider the above as "healthy" criticism.

Yes, I do -- I hope we can get something decent out in this in near future,
with duplicate filtering that can have useful options to be used directly
by MUAs and no duplicate filtering option which I can use in 
nottoomuch-addresses in 2016 ;D



> Thanks for quick review.
> -Michal


Tomi

• Previous message (by thread): Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

Thread:

• Michal Sojka—[PATCH 0/5] notmuch search --output=addresses [inbox, unread]
  • Michal Sojka—[PATCH 1/5] cli: Refactor option passing in the search command [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
      • Michal Sojka—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
        • Tomi Ollila—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
        • Jani Nikula—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
          • Michal Sojka—[PATCH v2 0/4] notmuch search --output=addresses [inbox, unread]
            • Michal Sojka—[PATCH v2 1/4] cli: Refactor option passing in the search command [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Michal Sojka—[PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Tomi Ollila—Re: [PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar [inbox, unread]
                • Michal Sojka—Re: [PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar [inbox, unread]
                  • Michal Sojka—[PATCH v3 0/4] notmuch search --output=sender/recipients [inbox, unread]
                    • Michal Sojka—[PATCH v3 1/4] cli: Refactor option passing in the search command [inbox, notmuch::obsolete, notmuch::patch, unread]
                      • Mark Walters—Re: [PATCH v3 1/4] cli: Refactor option passing in the search command [inbox, unread]
                    • Michal Sojka—[PATCH v3 2/4] cli: Add support for parsing multiple keyword arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
                    • Michal Sojka—[PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, notmuch::obsolete, notmuch::patch, unread]
                      • Tomi Ollila—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • Michal Sojka—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                          • Tomi Ollila—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                      • Mark Walters—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • Michal Sojka—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                      • Mark Walters—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • Tomi Ollila—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • David Edmondson—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                    • Michal Sojka—[PATCH v3 4/4] cli: Add an option to filter our duplicate addresses [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Michal Sojka—[PATCH v2 3/4] cli: Add support for parsing multiple keyword arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Michal Sojka—[PATCH v2 4/4] cli: Add configurable address deduplication for --output=addresses [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 2/5] cli: Extend the search command for --output=addresses and similar [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 3/5] cli: Add support for parsing command line "flag" options [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 4/5] cli: Add configurable address deduplication for --output=addresses [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 5/5] cli: Add tests for 'search --output=addresses' and similar [inbox, notmuch::obsolete, notmuch::patch, unread]