Re: [PATCH 1/5] cli: Refactor option passing in the search command

Subject: Re: [PATCH 1/5] cli: Refactor option passing in the search command

Date: Mon, 29 Sep 2014 20:28:26 +0300

To: Michal Sojka, Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Jani Nikula

On Thu, 25 Sep 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> On Thu, Sep 25 2014, Tomi Ollila wrote:
>> Although the test and the implementation in the next patches look OK, I'd
>> prefer the FLAG implementation Jani suggested earlier. IMO now that I
>> compare these two it looks cleaner and simpler...
>
> The question is which kind of simplicity you have in mind. I think that
> my version is simpler to type (less keystrokes). But if others have
> different opinion, I don't mind.

I'm biased, but I do like the implementation simplicity of my
approach. Adding the bash completion support is also trivial.

BR,
Jani.

• Previous message (by thread): Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients}

Thread:

• Michal Sojka—[PATCH 0/5] notmuch search --output=addresses [inbox, unread]
  • Michal Sojka—[PATCH 1/5] cli: Refactor option passing in the search command [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
      • Michal Sojka—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
        • Tomi Ollila—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
        • Jani Nikula—Re: [PATCH 1/5] cli: Refactor option passing in the search command [inbox, unread]
          • Michal Sojka—[PATCH v2 0/4] notmuch search --output=addresses [inbox, unread]
            • Michal Sojka—[PATCH v2 1/4] cli: Refactor option passing in the search command [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Michal Sojka—[PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Tomi Ollila—Re: [PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar [inbox, unread]
                • Michal Sojka—Re: [PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar [inbox, unread]
                  • Michal Sojka—[PATCH v3 0/4] notmuch search --output=sender/recipients [inbox, unread]
                    • Michal Sojka—[PATCH v3 1/4] cli: Refactor option passing in the search command [inbox, notmuch::obsolete, notmuch::patch, unread]
                      • Mark Walters—Re: [PATCH v3 1/4] cli: Refactor option passing in the search command [inbox, unread]
                    • Michal Sojka—[PATCH v3 2/4] cli: Add support for parsing multiple keyword arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
                    • Michal Sojka—[PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, notmuch::obsolete, notmuch::patch, unread]
                      • Tomi Ollila—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • Michal Sojka—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                          • Tomi Ollila—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                      • Mark Walters—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • Michal Sojka—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                      • Mark Walters—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • Tomi Ollila—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                        • David Edmondson—Re: [PATCH v3 3/4] cli: Extend the search command for --output={sender, recipients} [inbox, unread]
                    • Michal Sojka—[PATCH v3 4/4] cli: Add an option to filter our duplicate addresses [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Michal Sojka—[PATCH v2 3/4] cli: Add support for parsing multiple keyword arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Michal Sojka—[PATCH v2 4/4] cli: Add configurable address deduplication for --output=addresses [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 2/5] cli: Extend the search command for --output=addresses and similar [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 3/5] cli: Add support for parsing command line "flag" options [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 4/5] cli: Add configurable address deduplication for --output=addresses [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Michal Sojka—[PATCH 5/5] cli: Add tests for 'search --output=addresses' and similar [inbox, notmuch::obsolete, notmuch::patch, unread]