Re: v3 of test speedup by replacing gdb with LD_PRELOAD

Subject: Re: v3 of test speedup by replacing gdb with LD_PRELOAD

Date: Wed, 26 Jun 2019 22:06:15 +0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Tomi Ollila

On Wed, Jun 26 2019, Daniel Kahn Gillmor wrote:

> Here are the two patches from this series, revised according to the
> on-list discussion.
>
> In particular, the revision from Bremner's original series are:
>
>  * LD_PRELOAD is now prepended to, not clobbered (thanks, Tomi!)
>  * gen_insert_msg is not moved
>
> We still don't deal with platforms that don't support LD_PRELOAD (like
> MacOS), but i'd encourage us to take Ralph at his word and go ahead
> with these changes now, cleaning them up on those platforms later.

Agreed. Series LGTM.

>
>      --dkg

Tomi
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: v3 of test speedup by replacing gdb with LD_PRELOAD

Thread:

• David Bremner—start to replace dependence of test suite on gdb with LD_PRELOAD shims [inbox, unread]
  • David Bremner—[PATCH 1/2] test: provide machinery to make and use test_shims [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 1/2] test: provide machinery to make and use test_shims [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 1/2] test: provide machinery to make and use test_shims [inbox, signed, unread]
  • David Bremner—[PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, signed, unread]
      • Ralph Seichter—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, unread]
        • David Bremner—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, unread]
            • Tomi Ollila—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, unread]
              • Daniel Kahn Gillmor—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, signed, unread]
            • Ralph Seichter—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, signed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Tomi Ollila—Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH v2 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, signed, unread]
  • Daniel Kahn Gillmor—v3 of test speedup by replacing gdb with LD_PRELOAD [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH v3 1/2] test: provide machinery to make and use test_shims [inbox, notmuch::patch, notmuch::pushed, unread]
    • Daniel Kahn Gillmor—[PATCH v3 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh [inbox, notmuch::patch, notmuch::pushed, unread]
    • Tomi Ollila—Re: v3 of test speedup by replacing gdb with LD_PRELOAD [inbox, unread]
      • David Bremner—Re: v3 of test speedup by replacing gdb with LD_PRELOAD [inbox, unread]