Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

Subject: Re: [PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

Date: Mon, 10 Jun 2019 03:52:24 +0300

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor


One more nit-pick:

On Sun 2019-05-26 10:08:54 -0300, David Bremner wrote:
> +    test_expect_code 0 "notmuch_with_shim shim-$code insert --keep < \"$gen_msg_filename\""

This kind of business breaks obscurely if $gen_msg_filename happens to
have U+0022 QUOTATION MARK in it.  That's a pretty perverse situation,
but i'd generally prefer to use bash's builtin printf's %q for
robustness.

A revised patch will follow shortly that fixes both of my nitpicks.

  --dkg
signature.asc (application/pgp-signature)
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: