Re: [PATCH 0/3] Rewrite default reply format

Subject: Re: [PATCH 0/3] Rewrite default reply format

Date: Sat, 24 Mar 2012 12:06:06 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


Austin Clements <amdragon@MIT.EDU> writes:

> The default reply format is the last bastion of the old message
> formatter style.  This series converts it to the new self-recursive
> style.  After this, there will be one last series to rip out the
> compatibility code and do final cleanup.

Works fine, patches look good... just 2 "spacing" questions:

in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu"

+ typedef enum {
+     NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0,
+ } notmuch_show_text_part_flags;

Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0),

and this

+ * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each
+ * output line.
+ *

like:

+ * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each


Tomi

Thread: