Thanks for the review. New version coming shortly... Quoth Tomi Ollila on Mar 24 at 12:06 pm: > Austin Clements <amdragon@MIT.EDU> writes: > > > The default reply format is the last bastion of the old message > > formatter style. This series converts it to the new self-recursive > > style. After this, there will be one last series to rip out the > > compatibility code and do final cleanup. > > Works fine, patches look good... just 2 "spacing" questions: > > in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu" > > + typedef enum { > + NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0, > + } notmuch_show_text_part_flags; > > Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0), Changed to NOTMUCH_SHOW_TEXT_PART_REPLY = 1 << 0 to be consistent with operator spacing. I left out the parens since they aren't necessary. > and this > > + * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each > + * output line. > + * > > like: > > + * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each Changed. On this one I put in parens to better distinguish it from the surrounding prose. > Tomi