On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote: > Michal Sojka <sojkam1@fel.cvut.cz> writes: > >> This option allows to configure the criterion for duplicate address >> filtering. Without this option, all unique combinations of name and >> address parts are printed. This option allows to filter the output >> more, for example to only contain unique address parts. > > I had the feeling there was some "controversy" about the UI here, but > following back the 3 versions of the series I didn't see it. Does that > mean we just need to sanity check the code, or are there outstanding > bikes to shed? I have intentionally been guiet on this during the review process of the other patches to not slow down the acceptance of the others. I have not got enough time to look the implemenentation or think this last patch further -- from the user interface point of view I recall seeing there both useless features (but which might be warranted by implementation simplicity) and missing features (but which might not be there due to difficulty in implementation). Also, I am not sure whether the --filter-by is good option (and options descriptive...)... ...I'll look into this soon.... > > d Tomi