Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime.

Subject: Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime.

Date: Fri, 09 Mar 2012 12:50:03 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc: David Bremner

From: Tomi Ollila

On Thu,  8 Mar 2012 17:48:15 -0400, David Bremner <david@tethera.net> wrote:
> From: David Bremner <bremner@debian.org>
> 
> It seems that it has always been an error to try to parse an mbox
> format file with gmime without calling g_mime_parser_set_scan_from.

At least for the time being I think we should apply
http://en.wikipedia.org/wiki/Robustness_principle to this case
and accept email files that start with 'From '...

> This change reads the first 5 bytes of the file, and if they are "From ",
> declares the file to be an mbox.

an alternative to this is not to declare file as an mbox one but
if first line starts with 'From ' skip that line.

Whether this is a good idea or not I've already thought an implementation
how to do this which I'll post as an RFC patch in next 12 hours.


Tomi

• Previous message (by thread): Re: [PATCH] Handle errors in mime_node_open

Thread:

• David Bremner—Internal error on line 296 of mime-node.c [inbox, unread]
  • Austin Clements—Re: Internal error on line 296 of mime-node.c [inbox, unread]
    • David Bremner— [inbox, unread]
      • David Bremner—[PATCH 1/2] test: utility function to add a pre-generated message to the database. [inbox, unread]
      • David Bremner—[PATCH 2/2] test: add new test file for mime parsing. [inbox, unread]
  • Austin Clements—[PATCH] Handle errors in mime_node_open [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Parsing regression with gmime-2.6? [inbox, unread]
      • David Bremner—[WIP PATCH] debugging gmime-2.6 fail. [inbox, unread]
        • David Bremner—Re: [WIP PATCH] debugging gmime-2.6 fail. [inbox, unread]
      • Jameson Graef Rollins—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
      • Daniel Kahn Gillmor—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
        • Jameson Graef Rollins—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
          • Daniel Kahn Gillmor—Re: Parsing regression with gmime-2.6? [inbox, unread]
            • Jameson Graef Rollins—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
        • David Bremner—[PATCH] mime_node_open: check if the file is in mbox format, and inform gmime. [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime. [inbox, signed, unread]
          • Tomi Ollila—Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime. [inbox, unread]
            • David Bremner—[PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, unread]
            • David Bremner—[PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, unread]
              • Daniel Kahn Gillmor—Re: [PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, unread]
                • David Bremner—[PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Tomi Ollila—Re: [PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, signed, unread]
    • David Bremner—Re: [PATCH] Handle errors in mime_node_open [inbox, unread]