Re: [WIP PATCH] debugging gmime-2.6 fail.

Subject: Re: [WIP PATCH] debugging gmime-2.6 fail.

Date: Thu, 08 Mar 2012 14:08:39 -0400

To: notmuch@notmuchmail.org

Cc:

From: David Bremner

On Thu,  8 Mar 2012 11:35:35 -0400, David Bremner <david@tethera.net> wrote:


> I ran out of time for the moment, but the following patch gets me down from 
> 4196 failures on the notmuch mailing list to 3422.

That patch is of course complete nonsense. Attached is another silly
patch, which at least demonstrates the problem. With the attached patch,
notmuch (+ gmime-2.6) only fails for non-mbox messages. So I guess we
need a way to detect if a file is mbox before parsing? or a way to get
gmime to be less strict here?

• Previous message (by thread): Re: [PATCH] Handle errors in mime_node_open

Thread:

• David Bremner—Internal error on line 296 of mime-node.c [inbox, unread]
  • Austin Clements—Re: Internal error on line 296 of mime-node.c [inbox, unread]
    • David Bremner— [inbox, unread]
      • David Bremner—[PATCH 1/2] test: utility function to add a pre-generated message to the database. [inbox, unread]
      • David Bremner—[PATCH 2/2] test: add new test file for mime parsing. [inbox, unread]
  • Austin Clements—[PATCH] Handle errors in mime_node_open [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Parsing regression with gmime-2.6? [inbox, unread]
      • David Bremner—[WIP PATCH] debugging gmime-2.6 fail. [inbox, unread]
        • David Bremner—Re: [WIP PATCH] debugging gmime-2.6 fail. [inbox, unread]
      • Jameson Graef Rollins—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
      • Daniel Kahn Gillmor—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
        • Jameson Graef Rollins—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
          • Daniel Kahn Gillmor—Re: Parsing regression with gmime-2.6? [inbox, unread]
            • Jameson Graef Rollins—Re: Parsing regression with gmime-2.6? [inbox, signed, unread]
        • David Bremner—[PATCH] mime_node_open: check if the file is in mbox format, and inform gmime. [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime. [inbox, signed, unread]
          • Tomi Ollila—Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime. [inbox, unread]
            • David Bremner—[PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, unread]
            • David Bremner—[PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, unread]
              • Daniel Kahn Gillmor—Re: [PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, unread]
                • David Bremner—[PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Tomi Ollila—Re: [PATCH] mime_node_open: skip envelope from lines at the start of messages [inbox, signed, unread]
    • David Bremner—Re: [PATCH] Handle errors in mime_node_open [inbox, unread]