Re: [PATCH v3 00/10] Solaris support

Subject: Re: [PATCH v3 00/10] Solaris support

Date: Fri, 16 Nov 2012 08:59:11 +0200

To: Blake Jones


From: Tomi Ollila

On Thu, Nov 15 2012, Blake Jones <> wrote:

>> $ gcc compat/have_strsep.c
>> compat/have_strsep.c: In function "main":
>> compat/have_strsep.c:7:21: error: expected identifier or "(" before "const"
>> compat/have_strsep.c:9:29: error: "delim" undeclared (first use in this function)
>> compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in
>> zsh: exit 1     gcc compat/have_strsep.c
>> --- It is very easy to spot the problem ;)
> Sigh, yes it is.  I started my Solaris port using some patches from
> someone else who had done previous work on a Solaris port, and obviously
> I didn't look at the patch very closely.  In fact, after fixing
> have_strsep.c, I saw that I didn't even need it -- Solaris 11 has
> strsep() in libc.  But I'd prefer to clean up this patch and leave the
> compat version available for those compiling on older versions of
> Solaris, if that's okay.

It sure is okay -- the missing strsep() issue has been there before.

>> $ gcc compat/check_asctime.c
>> compat/check_asctime.c: In function "main":
>> compat/check_asctime.c:15:5: error: too many arguments to function "asctime_r"
>> In file included from compat/check_asctime.c:8:0:
>> /usr/include/time.h:266:14: note: declared here
>> zsh: exit 1     gcc compat/check_asctime.c
>> --- the posix-semantics way uses the 2-arg format. 
>> The logic of the test setting in this file doesn't open to
>> me. Why not test the same way as in getpwuid_r() case ?
> Yeah, that's clearly the right thing to do.  I was getting odd behavior
> when I defined _POSIX_PTHREAD_SEMANTICS for getpwuid_r(), and it looks
> like I fixed it in the wrong direction.
> Did you happen to notice any other issues besides these two?  I'd rather
> not spam the list with my ten-patch set if there's other silly stuff
> that needs cleaning up.

Nope, just those 2 :)

> Thanks again for testing this.
> Blake