Re: [PATCH 1/2] build: add canonicalize_file_name to symbols exported from libnotmuch.so

Subject: Re: [PATCH 1/2] build: add canonicalize_file_name to symbols exported from libnotmuch.so

Date: Mon, 14 Apr 2014 15:21:07 +0300

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Wed, Apr 09 2014, David Bremner <david@tethera.net> wrote:

> This is needed for our compat version of canonicalize_file_name to be used.
> ---

This series LGTM, just that this does not apply anymore (2nd patch, that is).

>  lib/gen-version-script.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
> index 76670d5..64a7374 100644
> --- a/lib/gen-version-script.sh
> +++ b/lib/gen-version-script.sh
> @@ -23,6 +23,6 @@ while read sym; do
>  	    ;;
>      esac
>  done
> -nm $* | awk '$1 ~ "^[0-9a-fA-F][0-9a-fA-F]*$" && $2 == "T" && $3 ~ "^get(line|delim)$" {print $3 ";"}'
> +nm $* | awk '$1 ~ "^[0-9a-fA-F][0-9a-fA-F]*$" && $2 == "T" && $3 ~ "^(getline|getdelim|canonicalize_file_name)$" {print $3 ";"}'
>  sed  -n 's/^[[:space:]]*\(notmuch_[a-z_]*\)[[:space:]]*(.*/ \1;/p' $HEADER
>  printf "local: *;\n};\n"
> -- 
> 1.9.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: