Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication

Subject: Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication

Date: Thu, 24 Sep 2015 22:55:33 +0300

To: David Bremner, Jani Nikula, notmuch@notmuchmail.org

Cc:

On Thu, Sep 24 2015, David Bremner <david@tethera.net> wrote:

> David Bremner <david@tethera.net> writes:
>
>> Jani Nikula <jani@nikula.org> writes:
>>
>>
>>> +    else
>>> +	v = !!m1->name - !!m2->name;
>>
>> Is this really idiomatic? It seems a little difficult to follow to me.
>>

For me it took a while to grasp the meaning of that but after I spent
a minute looking at it it become clear to me. this part +1

> Sorry, this stupid MUA I'm using confused me and I sent the reply
> halfway through reading the patch. Anyway, the rest looks OK.
>
> d

Tomi

Previous message (by thread): Re: [PATCH v2 0/9] cli: alternative address deduplication

Thread:

Jani Nikula—[PATCH v2 0/9] cli: alternative address deduplication [inbox, unread]
- Jani Nikula—[PATCH v2 1/9] cli: g_hash_table_lookup_extended is overkill [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 2/9] cli: abstract new mailbox creation [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 3/9] cli: add support for not deduplicating notmuch address results [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jani Nikula—[PATCH 3½/9] test: notmuch address --deduplicate=no tests [inbox, notmuch::patch, notmuch::pushed, unread]
    - David Bremner—Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests [inbox, unread]
      - Jani Nikula—Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests [inbox, unread]
- Jani Nikula—[PATCH v2 4/9] man: document notmuch address --deduplicate=(no|mailbox) option [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 4/9] man: document notmuch address --deduplicate=(no|mailbox) option [inbox, unread]
    - Jani Nikula—[PATCH] man: document notmuch address --deduplicate=(no|mailbox) option [inbox, notmuch::patch, notmuch::pushed, unread]
      - David Bremner—Re: [PATCH] man: document notmuch address --deduplicate=(no|mailbox) option [inbox, unread]
- Jani Nikula—[PATCH v2 5/9] util: move strcase_equal and strcase_hash to util [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 6/9] cli: change the data structure for notmuch address deduplication [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication [inbox, unread]
    - David Bremner—Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication [inbox, unread]
      - Tomi Ollila—Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication [inbox, unread]
    - Jani Nikula—Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication [inbox, unread]
      - David Bremner—Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication [inbox, unread]
        Jani Nikula—[PATCH 6/9 v3 part 1/2] util: add strcmp_null, a strcmp that handles NULL parameters [inbox, notmuch::patch, notmuch::pushed, unread]
        Jani Nikula—[PATCH 6/9 v3 part 2/2] cli: change the data structure for notmuch address deduplication [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 7/9] cli: add support for deduplicating based on case insensitive address [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jani Nikula—[PATCH 7½/9] test: add notmuch address --deduplicate=(no|mailbox|address) tests [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH 7½/9] test: add notmuch address --deduplicate=(no|mailbox|address) tests [inbox, unread]
      - Jani Nikula—[PATCH v2 7½/9] test: add notmuch address --deduplicate=(no|mailbox|address) tests [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 8/9] man: document notmuch address --deduplicate=address option [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 9/9] cli: do not sort addresses on --output=count or --deduplicate=address [inbox, notmuch::patch, notmuch::pushed, unread]
- David Bremner—Re: [PATCH v2 0/9] cli: alternative address deduplication [inbox, unread]
  - David Bremner—Re: [PATCH v2 0/9] cli: alternative address deduplication [inbox, unread]