Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

Subject: Re: [PATCH] emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

Date: Mon, 13 Feb 2012 21:14:40 +0200

To: Daniel Schoepe, Austin Clements, Dmitry Kurochkin

Cc: notmuch@notmuchmail.org

From: Tomi Ollila

On Mon, 13 Feb 2012 20:02:03 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:
> On Mon, 13 Feb 2012 10:29:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > Quoth Dmitry Kurochkin on Feb 13 at  3:09 pm:
> > > The notmuch-show view refresh function (`notmuch-show-refresh-view',
> > > bound to "=") accepts an optional RETAIN-STATE argument.  The patch
> > > allows to set this argument interactively by using "C-u =".
> > 
> > Why do we not *always* want this?
> 
> Seconded. And I don't think making that the default along with an easy
> way to get the old behavior is "too much" for one patch, even though
> "put that in a separate commit!" is a fairly common sentiment here, and
> not a bad one, most of the time.

I agree. If there is going to be 2 commits, first to change '=' retain
state and second to add previous behaviour by adding prefix argument handling.


> Cheers,
> Daniel

tomi

Thread: