Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to default templates

Subject: Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to default templates

Date: Thu, 31 Dec 2015 15:46:50 +0200

To: W. Trevor King, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Wed, Dec 30 2015, "W. Trevor King" <wking@tremily.us> wrote:

> Polishing the templates a bit.  Details in the individual patches.

This series LGTM. (html) tidy complains about imo irrelevant things -- or
I just did not know how to use it correctly -- as `| tidy -eq`.

>
> Cheers,
> Trevor

Tomi


PS: it was a bit difficult to test, had to resort to reading sources
and experment with some git commands. So (i.e. Note to self):

$ git --git-dir ./.nmbug cat-file -p remotes/origin/config:status-config.json > ~/tmp/nmbug...
$ PYTHONPATH=$PWD/bindings/python python2.7 devel/nmbug/nmbug-status --config ~/tmp/nmbug...

(and | tidy -eq )


>
> W. Trevor King (2):
>   nmbug-status: Adjust headers to start with h1
>   nmbug-status: Fix unbalanced <p> tags in default header/footer
>
>  devel/nmbug/nmbug-status | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> -- 
> 2.1.0.60.g85f0837
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Thread: