Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to default templates

Subject: Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to default templates

Date: Thu, 31 Dec 2015 08:43:12 -0800

To: Tomi Ollila

Cc: notmuch@notmuchmail.org

From: W. Trevor King


On Thu, Dec 31, 2015 at 03:46:50PM +0200, Tomi Ollila wrote:
> This series LGTM. (html) tidy complains about imo irrelevant things
> -- or I just did not know how to use it correctly -- as `| tidy
> -eq`.

That doesn't complain about anything with the current tidy 5.1.25 [1]
with output built by this branch (although I ran it on output for a
non-notmuch tag-set).

> PS: it was a bit difficult to test, had to resort to reading sources
> and experment with some git commands. So (i.e. Note to self):
> 
> $ git --git-dir ./.nmbug cat-file -p remotes/origin/config:status-config.json > ~/tmp/nmbug...

There's a sample status-config.json in devel/nmbug/, so you don't have
to check with the version in the nmbug repository if you don't want
to.

> $ PYTHONPATH=$PWD/bindings/python python2.7 devel/nmbug/nmbug-status --config ~/tmp/nmbug...

Yeah, if you don't have the ‘notmuch’ package installed globally,
you'll need to do something like this (although nmbug-status should
work with Python 2.6+, including the 3.x line).  The error you get
from not having notmuch installed should be fairly understandable
though:

  $ nmbug-status
  Traceback (most recent call last):
    File "./nmbug-status", line 422, in <module>
      import notmuch
  ImportError: No module named 'notmuch'

So I'd recommend either:

  $ PYTHONPATH=$PWD/bindings/python python2.7 devel/nmbug/nmbug-status --config devel/nmbug/status-config.json

or installing notmuch with its Python bindings using your package
manager and running:

  $ ./devel/nmbug/nmbug-status --config devel/nmbug/status-config.json

Cheers,
Trevor

[1]: http://www.html-tidy.org/

     “Tidy reborn, Thanks for the efforts of HTACG and prominent
     contributors, HTML Tidy has a whole new heartbeat and a whole new
     life.”

     Maybe your distro-packaged tidy is just old?  I have Tidy
     20090325 from Gentoo, but 5.1.25 was cut on 2015-11-23 [2].

[2]: https://github.com/htacg/tidy-html5/releases

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc (application/pgp-signature)

Thread: