Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

Subject: Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

Date: Tue, 10 Jan 2012 15:47:42 +0000

To: Austin Clements

Cc: notmuch@notmuchmail.org

From: David Edmondson


On Tue, 10 Jan 2012 10:36:50 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> LGTM, though would it be easier to put this in the else clause of the
> if after the setq count?

Agreed. I got confused thinking about it due to the empty elements in
the matrix, but perhaps that doesn't matter. I'll continue to think, but
would rather not delay fixing the bug.

> Is it possible for a tag in the last column to be just long enough to
> make the line still wrap?  Somehow my current tag set doesn't trigger
> this bug, so I can't test this case (and I admit I can't follow
> notmuch-hello-insert-tags well enough to reason this out).

With a sufficiently narrow window it's always possible to generate wrap,
of course. I couldn't make it happen for any window width that seemed
reasonable.
part-000.sig (application/pgp-signature)

Thread: