David was a bit hasty with pushing compact, so I missed the review. Instead of just whining about it, here's a few changes I'd really like to see merged before release. Completely untested, needs man page updates and probably test changes too, so there's a bit more to do still. Hint, if you have the time, just pick up from here. ;) Cheers, Jani. Jani Nikula (6): lib: construct compactor within try block to catch any exceptions lib: add closure parameter to compact status update callback lib: use the backup path provided by the user, don't add anything to it cli: return error status if compaction fails cli: add compact --backup=FILE option, don't backup by default cli: add compact --verbose option and silence output without it lib/database.cc | 29 ++++++++++++++--------------- lib/notmuch.h | 5 +++-- notmuch-compact.c | 46 +++++++++++++++++++++++++++------------------- 3 files changed, 44 insertions(+), 36 deletions(-) -- 1.7.2.5