Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

Subject: Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

Date: Sat, 2 Nov 2013 14:22:37 +0200

text/plain
text/html

On Nov 2, 2013 2:14 PM, "David Bremner" <david@tethera.net> wrote:
>
> Jani Nikula <jani@nikula.org> writes:
>
> > Adding another level is just useless cruft.
> > ---
> >  lib/database.cc   |   14 ++++----------
> >  notmuch-compact.c |    4 ++--
> >  2 files changed, 6 insertions(+), 12 deletions(-)
>
> The first two patches are fine, modulo my comments about documentation.
> I think the backup path needs to be updated in notmuch-compact.c, and
> possible the test updated (after applying
> id:1383350515-24320-1-git-send-email-david@tethera.net)
>
> d

Ah, right, I was juggling the patch order back and forth a bit, and I
missed this (as I drop the path completely in a later patch).

Jani.

Previous message (by thread): Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

Thread:

Jani Nikula—[PATCH 0/6] compactor changes [inbox, unread]
- Jani Nikula—[PATCH 1/6] lib: construct compactor within try block to catch any exceptions [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH 2/6] lib: add closure parameter to compact status update callback [inbox, notmuch::obsolete, notmuch::patch, unread]
  - david@tethera.net—[PATCH] lib: update documentation of callback functions for database_compact and database_upgrade. [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Jani Nikula—Re: [PATCH] lib: update documentation of callback functions for database_compact and database_upgrade. [inbox, unread]
      - David Bremner—Re: [PATCH] lib: update documentation of callback functions for database_compact and database_upgrade. [inbox, unread]
- Jani Nikula—[PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it [inbox, unread]
    - Jani Nikula—Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it [inbox, unread]
- Jani Nikula—[PATCH 4/6] cli: return error status if compaction fails [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH 5/6] cli: add compact --backup=FILE option, don't backup by default [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH 6/6] cli: add compact --verbose option and silence output without it [inbox, notmuch::obsolete, notmuch::patch, unread]