Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

Subject: Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types

Date: Mon, 28 Nov 2011 13:36:44 +0100

To: Sebastian Spaeth, notmuch@notmuchmail.org

Cc:

From: Justus Winter

Quoting Sebastian Spaeth (2011-11-02 08:25:53)
>On Mon, 10 Oct 2011 00:12:53 +0200, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:
>> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
>> ---
>>  bindings/python/notmuch/globals.py |   38 +++++++++++++++++++++++++++++++++++-
>
>Hi there, catching up on email, sorry for the delay.
>I am not opposed to the change, but I fail to see any justification for
>a whole lot more complexity either. What was wrong with the previous
>approach?

Well, quoting my commit message:

> Add type information to the ctypes._FuncPtr wrappers and
> use the wrapper classes instead of c_void_p for pointers
> to notmuch_*_t.
>
> This enables the ctypes library to type check parameters
> being handed to functions from the notmuch library.

Justus

• Previous message (by thread): Re: [PATCH] lib: update documentation for notmuch_database_get_directory

Thread:

• Justus Winter—[PATCH 1/2] python: add classes to wrap all notmuch_*_t types [inbox, notmuch::patch, notmuch::pushed, notmuch::python, unread]
  • Justus Winter—[PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, notmuch::patch, notmuch::pushed, notmuch::python, unread]
    • Patrick Totzke—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, notmuch::bug, notmuch::moreinfo, notmuch::python, unread]
      • Sebastian Spaeth—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, signed, unread]
        • Patrick Totzke—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [attachment, inbox, unread]
      • Sebastian Spaeth—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, signed, unread]
        • Justus Winter—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [attachment, inbox, notmuch::bug, notmuch::moreinfo, notmuch::python, unread]
        • Justus Winter—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [attachment, inbox, notmuch::bug, notmuch::moreinfo, notmuch::python, unread]
          • David Bremner—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, unread]
            • Justus Winter—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, unread]
              • David Bremner—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, unread]
                • David Bremner—[PATCH] lib: update documentation for notmuch_database_get_directory [inbox, notmuch::patch, notmuch::pushed, unread]
                  • Tomi Ollila—Re: [PATCH] lib: update documentation for notmuch_database_get_directory [inbox, unread]
                  • David Bremner—Re: [PATCH] lib: update documentation for notmuch_database_get_directory [inbox, unread]
      • David Bremner—Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types [inbox, unread]
  • Sebastian Spaeth—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [inbox, signed, unread]
    • Justus Winter—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [attachment, inbox, unread]
      • Sebastian Spaeth—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [inbox, signed, unread]
        • James Westby—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [inbox, unread]
          • Justus Winter—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [attachment, inbox, unread]
            • James Westby—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [inbox, unread]
              • James Westby—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [inbox, unread]
                • Justus Winter—Re: [PATCH 1/2] python: add classes to wrap all notmuch_*_t types [attachment, inbox, unread]