Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types

Subject:Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types

Date:Tue, 06 Dec 2011 13:05:53 +0100

To:Patrick Totzke ,Justus Winter ,notmuch@notmuchmail.org

Cc:

From:Sebastian Spaeth


On Tue, 06 Dec 2011 10:46:31 +0000, Patrick Totzke <patricktotzke@googlemail.com> wrote:
> This commit breaks raising XapianErrors for me.
> 
> If I lock the index with some `notmuch tag +test '*'`
> and try to write to it in alot, i get a segfault and
> the following on stderr:
> 
> Xapian exception occurred opening database: Unable to get write lock on
> /home/pazz/mail/.notmuch/xapian: already locked

Hi Justus,
I can confirm that this patch breaks as Totzke has described it:

http://git.notmuchmail.org/git/notmuch/commitdiff/3434d194026ff65217d9342ffe511f67fd71e79f

This change makes python segfault with a Xapianerror on stdout rather
than the python exception that we were seeing before this patch.

-     _open.restype = c_void_p
+     _open.restype = NotmuchDatabaseP


As the patch obviously fixed other crashers I would like to not revert
it. Can you have a look and see if you find a cause of that?

Sebastian
part-000.sig (application/pgp-signature)

Thread: