Re: [PATCH] emacs: Re-apply an old patch to fold/unfold threads in tree-view

Subject: Re: [PATCH] emacs: Re-apply an old patch to fold/unfold threads in tree-view

Date: Tue, 31 Aug 2021 21:28:30 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc: Julien Masson

From: inwit


On Tue Aug 31, 2021 at 5:15 PM CEST, David Bremner wrote:
> Thanks for reviving this.
My pleasure.

> Eventually you'll want to add a proper commit
> message and address some of the previous review.
Will do, eventually (see below).

> There seems to be problems introducing this overlay. I either don't
> see it, or it is added to the wrong buffer.
I've seen it too. From what I've tried, it happens when you try to fold
the last thread on a buffer.

> For me the tree-view goes away and [...] is applied to the *scratch*
> buffer. I suspect this bug was in the original patch.
Yeah, since I haven't really done anything, the original patch is indeed
to blame.

My main problem is that I don't really know where to start debugging it.
I'm afraid my elisp powers don't reach that far. :(

> About the binding, have a look at devel/emacs-key-bindings.org to help
> choose a key; a final version of the patch should update that file and
> doc/notmuch-emacs.rst
Will do. In case we can fix the bug.

Regards,
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: