inwit <inwit@sindominio.net> writes: Thanks for reviving this. Eventually you'll want to add a proper commit message and address some of the previous review. But first, I think I found a bug, see below > --- > emacs/notmuch-tree.el | 92 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > > diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el > index b48a132d..24b4105b 100644 > --- a/emacs/notmuch-tree.el > +++ b/emacs/notmuch-tree.el > @@ -131,6 +131,11 @@ Note that the author string should not contain whitespace > notmuch-unthreaded-result-format > notmuch-tree-result-format)) > > +(defcustom notmuch-tree-overlay-string " [...]" > + "String displayed at the beginning of the overlay" > + :type 'string > + :group 'notmuch-tree) There seems to be problems introducing this overlay. I either don't see it, or it is added to the wrong buffer. To reproduce, go to *scratch*, write (notmuch-tree "thread:{id:20210831110111.3148499-1-inwit@sindominio.net}") at the end, of the line, C-x C-e in the resulting tree-view, type 't' to toggle thread hiding. For me the tree-view goes away and [...] is applied to the *scratch* buffer. I suspect this bug was in the original patch. About the binding, have a look at devel/emacs-key-bindings.org to help choose a key; a final version of the patch should update that file and doc/notmuch-emacs.rst _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org