On Thu, Oct 17 2024, David Bremner wrote:

> Pengji Zhang <me@pengjiz.com> writes:
> [... 7 lines elided]
>>> The current behavior of notmuch accords with the user values of below
>>> and traditional but not above.
>>>
>>> The notmuch function responsible for the position of the signature
>>> (or, rather, the position of the citations) is notmuch-mua-reply. I
>>> have attached a patch that adds a brief snippet which obeys
>>> message-cite-reply-position when its value is above.
>
> Since this is a new feature, we'd normally expect a test or two.
>
> you can find some examples in test/T453-emacs-reply.sh
>
> d

Hello,

Thank you for letting me know about Notmuch's test suite. I've attached
two patches. 001 implements the code for the feature, and 002 includes
the tests for each of the three possible values of
message-cite-reply-position: above, traditional, and below.

Regarding the expected behavior: a value of above and below are
self-explanatory, however, a value of traditional is unclear. The
docstring for message-cite-reply-position states:

    Where the reply should be positioned.
    If ‘traditional’, reply inline.
    If ‘above’, reply above quoted text.
    If ‘below’, reply below quoted text.

As far as I can tell, there is no effective difference between the
values of traditional and below There is hardly any documentation on the
matter in message.el, but looking at the source code traditional doesn't
seem to be treated specially. So I've treated them as equivalent in my
test cases.

Please let me know if any modifications are in order.

-- 
In gratitude,
Kristoffer

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org