Kristoffer Balintona <krisbalintona@gmail.com> writes:

> On Thu, Oct 17 2024, David Bremner wrote:
>
> Thank you for letting me know about Notmuch's test suite. I've attached
> two patches. 001 implements the code for the feature, and 002 includes
> the tests for each of the three possible values of
> message-cite-reply-position: above, traditional, and below.
>

thanks for writing some tests.

>
> Please let me know if any modifications are in order.

Your patches don't seem to have commit messages. You can
use git-format-patch to include them. See also

   https://notmuchmail.org/contributing/#index5h2

for hints about appropriate commit messages.

> +      (when (or (eq message-cite-reply-position 'above)
> +                (and message-cite-style
> +                     (eq (eval (cadr

Is it possible to avoid the eval here? I am nervous about the
security implications (side effects e.g.) of using eval.

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org