Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.

Date: Mon, 9 Jan 2012 18:59:47 -0700

To: Aaron Ecay

Cc: notmuch@notmuchmail.org

From: Adam Wolfe Gordon


On Sun, Jan 8, 2012 at 18:27, Aaron Ecay <aaronecay@gmail.com> wrote:
>> +(defun w3m-region (start end)) ;; From `w3m.el'.
>
> What is the purpose of the above line?  If it is to make the compiler
> aware of the function, you should use ‘declare-function’ instead.  Defun
> will erase the original definition of the w3m-region function.

Indeed, it's to make the compiler aware of the function.  I followed
the example of notmuch-show.el (defvar w3m-current-buffer, line 391),
but it sounds like declare-function is a better way to accomplish
this.  I haven't written a whole lot of emacs lisp, so thanks for the
tip.

Given David's comments about requiring w3m instead it might be moot,
but if not I'll make this change for the next version.

Thread: