Re: [PATCH 2/2] lib: fix glibc-2.43 w/ clang

Subject: Re: [PATCH 2/2] lib: fix glibc-2.43 w/ clang

Date: Mon, 16 Feb 2026 09:46:55 +0100

To: David Bremner

Cc: Nicolas PARLANT, notmuch@notmuchmail.org

From: Michael J Gruber


Am So., 15. Feb. 2026 um 23:13 Uhr schrieb David Bremner <david@tethera.net>:
>
> Nicolas PARLANT <nicolas.parlant@parhuet.fr> writes:
>
> >>notmuch-insert.c:136:11: error: assigning to 'char *' from 'const char *'
> >>      discards qualifiers
> >>      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> >>  136 |     slash = strrchr (path, '/');
> >>      |           ^ ~~~~~~~~~~~~~~~~~~~
>
> Thanks for the patch. The change itself looks fine, but the (subject of)
> the commit message is a bit cryptic. We use "lib:" for code in the lib/
> or (maybe util/) directory. This is obvious not a fix for glibc, but
> that's what a naive reader (like me) might think.

That makes two of us :)

Also: How is the patch related to glibc version? Has the declaration
of strrchr() changed?

Michael
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: