Re: [PATCH 2/2] lib: fix glibc-2.43 w/ clang

Subject: Re: [PATCH 2/2] lib: fix glibc-2.43 w/ clang

Date: Mon, 16 Feb 2026 07:12:54 +0900

To: Nicolas PARLANT, notmuch@notmuchmail.org

Cc:

From: David Bremner


Nicolas PARLANT <nicolas.parlant@parhuet.fr> writes:

>>notmuch-insert.c:136:11: error: assigning to 'char *' from 'const char *'
>>      discards qualifiers
>>      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>>  136 |     slash = strrchr (path, '/');
>>      |           ^ ~~~~~~~~~~~~~~~~~~~

Thanks for the patch. The change itself looks fine, but the (subject of)
the commit message is a bit cryptic. We use "lib:" for code in the lib/
or (maybe util/) directory. This is obvious not a fix for glibc, but
that's what a naive reader (like me) might think.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: