Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

Date: Mon, 04 Nov 2013 15:06:07 -0500

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Ben Gamari


David Bremner <david@tethera.net> writes:

> Ben Gamari <bgamari.foss@gmail.com> writes:
>
>> We never checked to ensure that the rmtree() of the old database
>> succeeded.
>>
>
> Is there some reason these patches (and the existing compact code in the
> lib) is using fprintf and not the status callback function? Most places
> we don't (yet) have logging callbacks, but here we do.
>
Nope. I simply wasn't aware of this infrastructure. I can put together a
patch to fix this.

Cheers,

- Ben
part-000.sig (application/pgp-signature)

Thread: